Remove processed attestation log #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
@@ Coverage Diff @@
## master #4040 +/- ##
===========================================
+ Coverage 0 36.72% +36.72%
===========================================
Files 0 326 +326
Lines 0 9242 +9242
Branches 0 1505 +1505
===========================================
+ Hits 0 3394 +3394
- Misses 0 5657 +5657
- Partials 0 191 +191 |
wemeetagain
requested changes
May 24, 2022
| aggregationBits: ssz.phase0.CommitteeBits.toJson(attestation.aggregationBits) as string, | ||
| }); | ||
| export function onAttestation(this: BeaconChain, _: phase0.Attestation): void { | ||
| // do nothing for now |
There was a problem hiding this comment.
Can you add a more descriptive comment sharing why we aren't logging here? Maybe linking to #4032 or adding some of the reasoning from that
twoeths
force-pushed
the
tuyen/remove-processed-attestation-log
branch
from
2c1bc7c
to
cee78a1
Compare
wemeetagain
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the "Attestation processed" log, this log account for roughly 80% of log file
Description
Replace #4032